[ts] Upgrade to TypeScript 3.9.2 #8280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
requested review from
EvanBacon,
IjzerenHein,
bbarthec,
lukmccall,
mczernek,
sjchmiela and
tsapeta
as code owners
ide
force-pushed
the
@ide/ts-3.9
branch
2 times, most recently
from
e852508 to
8955e7a
Compare
ide
requested review from
brentvatne
and removed request for
EvanBacon,
IjzerenHein,
bbarthec,
lukmccall,
mczernek,
sjchmiela and
tsapeta
Contributor
|
Native Component List for this branch is ready |
Member
Author
|
Something hokey is up with CI, namely, TS 3.7.3 is being used because another package pulls it in. Evan is working on removing it but ideally expo-module-scripts should defend against this. |
bbarthec
approved these changes
May 13, 2020
This upgrades TypeScript to 3.9.2 to keep us more up to date. It also supports `@ts-expect-error` for places where we want to get notified if a future TS version stops triggering type checker errors. https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/ It is also supposed to be faster but I don't have real numbers on this. CI might be a reasonable indicator. Also updated ts-jest, since there was a bug that required clearing the Jest cache. Updated the TS version in expo-module-scripts. Ran `expotools check-packages --no-uniformity-check ` to rebuild, test, and lint all files.
1 task
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* [ts] Upgrade to TypeScript 3.9.2 This upgrades TypeScript to 3.9.2 to keep us more up to date. It also supports `@ts-expect-error` for places where we want to get notified if a future TS version stops triggering type checker errors. https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/ It is also supposed to be faster but I don't have real numbers on this. CI might be a reasonable indicator. Also updated ts-jest, since there was a bug that required clearing the Jest cache. Updated the TS version in expo-module-scripts. Ran `expotools check-packages --no-uniformity-check ` to rebuild, test, and lint all files. * [ts] Fix up files for TS 3.9 * [ts] Rebuild JS files with TS 3.9.2
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
* [ts] Upgrade to TypeScript 3.9.2 This upgrades TypeScript to 3.9.2 to keep us more up to date. It also supports `@ts-expect-error` for places where we want to get notified if a future TS version stops triggering type checker errors. https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/ It is also supposed to be faster but I don't have real numbers on this. CI might be a reasonable indicator. Also updated ts-jest, since there was a bug that required clearing the Jest cache. Updated the TS version in expo-module-scripts. Ran `expotools check-packages --no-uniformity-check ` to rebuild, test, and lint all files. * [ts] Fix up files for TS 3.9 * [ts] Rebuild JS files with TS 3.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This upgrades TypeScript to 3.9.2 to keep us more up to date. It also supports
@ts-expect-errorfor places where we want to get notified if a future TS version stops triggering type checker errors. https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/It is also supposed to be faster but I don't have real numbers on this. CI might be a reasonable indicator.
How
Updated the TS version in expo-module-scripts.
Test Plan
Ran
expotools check-packagesto rebuild, test, and lint all files.