[docs] Add info about new IcoMoon app#43191
Merged
amandeepmittal merged 4 commits intoFeb 17, 2026
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
tomekzaw
changed the title
amandeepmittal
requested changes
Feb 17, 2026
amandeepmittal
left a comment
amandeepmittal
left a comment
Member
There was a problem hiding this comment.
Thank you for the update! I've left one tiny suggestion to improve readability.
Co-authored-by: Aman Mittal <[email protected]>
Contributor
Author
|
Thanks for the review, fixed! |
amandeepmittal
approved these changes
Feb 17, 2026
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
# Why The [new IcoMoon app](https://icomoon.io/new-app) exports a different JSON format than the [old IcoMoon app](https://icomoon.io/app). The current `createIconSetFromIcoMoon` function in `@expo/vector-icons` only supports the old app's output, so users who export from the new app encounter issues. expo/vector-icons#356 adds support for the new format. This documentation update clarifies the situation and points users to that PR until it is released. # How Added a note in the `createIconSetFromIcoMoon` section in the docs about icons. # Test Plan Make sure that the `createIconSetFromIcoMoon` section renders correctly. # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The new IcoMoon app exports a different JSON format than the old IcoMoon app. The current
createIconSetFromIcoMoonfunction in@expo/vector-iconsonly supports the old app's output, so users who export from the new app encounter issues. expo/vector-icons#356 adds support for the new format. This documentation update clarifies the situation and points users to that PR until it is released.How
Added a note in the
createIconSetFromIcoMoonsection in the docs about icons.Test Plan
Make sure that the
createIconSetFromIcoMoonsection renders correctly.Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).