fix(cli,log-box): Drop obsolete rawBody parsing from createMetroMiddleware#43074
Merged
kitten merged 6 commits intoFeb 11, 2026
Merged
Conversation
This increases the efficiency of the `Body` helper but doesn't change things otherwise. Older versions are fine and this is optional for this branch.
kitten
requested review from
EvanBacon,
byCedric,
hassankhan and
krystofwoldrich
February 11, 2026 14:58
Contributor
|
Subscribed to pull request
Generated by CodeMention |
kitten
force-pushed
the
@kitten/refactor/drop-raw-body-workaround-for-metro
branch
from
February 11, 2026 14:59
82b4d43 to
39e0672
Compare
expo-bot
added
bot: passed checks
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 34399b4 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/@expo/log-box",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "6e9f78bcd240b779dcce6c6f0c024d527571b924"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/@expo/log-box",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "5f1c6eec678649e4e0485d58871b8055bb798445"
}
}
]Generated by PR labeler 🤖 |
kitten
commented
Feb 11, 2026
| return next(); | ||
| } | ||
| try { | ||
| const frame = await new Body(req).json(); |
Member
Author
There was a problem hiding this comment.
This is equivalent to using json from node:stream/consumers. However, I've put in fetch-nodestream's Body here since it's more portable, so using this in more places aligns us to Web-like usage, as we adopt more of this over time
vonovak
approved these changes
Feb 11, 2026
byCedric
approved these changes
Feb 11, 2026
kitten
deleted the
@kitten/refactor/drop-raw-body-workaround-for-metro
branch
February 11, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Supersedes #35757
This also raised that we had two calls to
/symbolicatethat weren't being called withapplication/json. However, without therawBodyproperty, Metro's middlewares now expect theContent-Type: application/jsonheader.How
@expo/log-boxto setContent-Type: application/jsonon JSON POST requests@expo/clito setContent-Type: application/jsonon internal/symbolicaterequestrawBodyMiddlewarefrom CLI'screateMetroMiddlewarerawBodywith JSON body parsing for/open-stack-frameTest Plan
/symbolicatecall should work as before/open-stack-frameshould work as beforeChecklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).