[web-browser] Add experimental macOS support#37352
Merged
gabrieldonadel merged 4 commits intomainfrom Jun 11, 2025
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: c408bc8 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-web-browser/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "41c11ae6b29d63dd49876715339b60bb58bd30a4"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-web-browser/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "29f458e502c72201a4213af7d206ea5acf12ca68"
}
}
]Generated by PR labeler 🤖 |
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Jun 11, 2025
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
Jun 11, 2025
| case .fullScreen, .overFullScreen: | ||
| if let screenFrame = NSScreen.main?.frame { | ||
| return screenFrame | ||
| } else { |
Collaborator
There was a problem hiding this comment.
🟠 SwiftLint: Superfluous Else Violation
Else branches should be avoided when the previous if-block exits the current scope
expo-bot
added
bot: suggestions
gabrieldonadel
added a commit
that referenced
this pull request
Jun 11, 2025
# Why I'm attempting to slowly add macOS support to more of our libraries, and at the same time, reduce the number of custom modules on Orbit. # How Add experimental macOS support # Test Plan Run BareExpo on macOS https://github.com/user-attachments/assets/bd9971f5-d7f7-4b13-a82b-69e1afb649e3 # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
gabrieldonadel
added
the
published
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I'm attempting to slowly add macOS support to more of our libraries, and at the same time, reduce the number of custom modules on Orbit.
How
Add experimental macOS support
Test Plan
Run BareExpo on macOS
Screen.Recording.2025-06-10.at.21.11.30.mov
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).