[cli] Remove rawBody handling on /symbolicate endpoint#35757
Closed
huntie wants to merge 1 commit into
Closed
Conversation
huntie
force-pushed
the
drop-symbolicate-handling
branch
2 times, most recently
from
March 28, 2025 14:33
eb22657 to
c30f810
Compare
expo-bot
added
bot: passed checks
huntie
force-pushed
the
drop-symbolicate-handling
branch
from
March 28, 2025 14:52
c30f810 to
58465ee
Compare
Member
|
I approved the CI for this PR, but we can only merge this once the Metro changes are published and we switched over to that Metro version on |
huntie
marked this pull request as ready for review
March 28, 2025 16:11
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Author
|
@byCedric Cool, makes sense. I've published the PR; we'll come back to it later. |
huntie
force-pushed
the
drop-symbolicate-handling
branch
from
April 28, 2025 13:59
58465ee to
aab8c03
Compare
Author
|
Push: Resolve CHANGELOG.md conflict. @byCedric I think if Expo has updated Metro by now, we can E2E validate this and merge. |
Author
|
@byCedric We shipped Metro 0.82.2 with the relevant change. |
Member
|
We can't merge this until all requests to Edit: This seems to be a trivial update for, us so I'll file a replacement PR |
3 tasks
kitten
added a commit
that referenced
this pull request
Feb 11, 2026
…ddleware` (#43074) # Why Supersedes #35757 > This removes a longstanding hack that covered for a lack of JSON body parsing in Metro's `/symbolicate` endpoint. We're now resolving this in react/metro#1475 — meaning this can be removed from Expo CLI. > — @huntie This also raised that we had two calls to `/symbolicate` that weren't being called with `application/json`. However, without the `rawBody` property, Metro's middlewares now expect the `Content-Type: application/json` header. # How - Update `@expo/log-box` to set `Content-Type: application/json` on JSON POST requests - Update `@expo/cli` to set `Content-Type: application/json` on internal `/symbolicate` request - Drop `rawBodyMiddleware` from CLI's `createMetroMiddleware` - Replace `rawBody` with JSON body parsing for `/open-stack-frame` # Test Plan - Run app and cause an error with a stack trace - The `/symbolicate` call should work as before - Clicking a frame, `/open-stack-frame` should work as before # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This removes a longstanding hack that covered for a lack of JSON body parsing in Metro's
/symbolicateendpoint. We're now resolving this in react/metro#1475 — meaning this can be removed from Expo CLI.Related PRs:
How
Delete interception of
/symbolicatein Expo CLI middleware stack.Test Plan
metrointo a local checkout of Expo viayarn link.cd apps/bare-expoyarn ios[Incoming]
Important
We'll wait for the relevant release of Metro to land on
mainfirst. See @byCedric's comment below.Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).