Repository navigation
[eas-cli] remove deprecated GraphQL field usage - #4021
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4021 +/- ##
==========================================
- Coverage 63.35% 63.34% -0.01%
==========================================
Files 1026 1026
Lines 46828 46841 +13
Branches 9825 9830 +5
==========================================
+ Hits 29662 29665 +3
- Misses 17064 17074 +10
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tchayen
changed the title
tchayen
changed the title
c699448 to
a1f3ec7
Compare
szdziedzic
left a comment
szdziedzic
left a comment
There was a problem hiding this comment.
It's 99% correct, although I found 1 problem:
| }; | ||
|
|
||
| export type UpdateJsonInfo = { branch: string } & Pick< | ||
| export type UpdateJsonInfo = { branch: string; runtimeVersion: string } & Pick< |
There was a problem hiding this comment.
This leaves the update JSON contract inconsistent. getUpdateJsonInfosForUpdates maps the new runtime object back to the legacy flat runtimeVersion, so commands such as eas update --json, update:view, and update:edit retain the old shape. Meanwhile, update:republish --json prints the raw UpdateFragment and emits nested runtime.
This seems to be breaking change.
We should probably map it to runtimeVersion as well for republish.
There was a problem hiding this comment.
It is a breaking change, yes. For now I reversed it to remap the field and dropped changelog mention of it. WDYT: do we want to minimize breaking changes (or even avoid at all cost) or are we ok to have a cut off point now and release a major?
|
cc: @wschurman or @quinlanj if you want to take a look at update specific things |
657ab6e to
8d2cbb5
Compare
tchayen
changed the title
This reverts commit 32264ae.
Co-authored-by: tchayen <[email protected]>
…d build Read it from Build.appIdentifier instead of the deprecated androidConfig.applicationIdentifier. Co-authored-by: tchayen <[email protected]>
bc5a534 to
db90b44
Compare
|
✅ Thank you for adding the changelog entry! |
Why
We can remove deprecated fields that are not used by the CLI anymore.
How
BuildFragment:project->app,channel->updateChannel { id name },runtimeVersion->runtime { id version }(this is a breaking change noted in changelog).build:cancelusescancelBuild,AccountFragmentreplaces the fulluserslist withviewerUserPermission { role },Account.appleTeamsmoves toappleTeamsPaginated, dropped deprecatedselectedImage.Build.appIdentifierinstead ofandroidConfig.applicationIdentifier.Test plan
CI passes. Tested against staging with test account.