visualize_spans function + manual argument + docstrings#37
Merged
pmbaumgartner merged 9 commits intomasterfrom Jun 14, 2022
Merged
visualize_spans function + manual argument + docstrings#37pmbaumgartner merged 9 commits intomasterfrom
visualize_spans function + manual argument + docstrings#37pmbaumgartner merged 9 commits intomasterfrom
Conversation
visualize_spans functionvisualize_spans function + manual argument + docstrings
Contributor
Author
|
I've added a few more updates, so the name of this branch is a bit of misnomer now. I've updated I've also updated the docstrings to include this argument, as well as added the args to the docstrings for |
ines
reviewed
Jun 13, 2022
ines
approved these changes
Jun 13, 2022
rmitsch
approved these changes
Jun 13, 2022
pmbaumgartner
commented
Jun 13, 2022
Contributor
Author
rmitsch
reviewed
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a
visualize_spansfunction for using the span visualization in displaCy.I made a few choices that may need justification:
spans_keyis part of theoptionspassed to displaCy, it feels critical enough to pass as an argument tovisualize_spansrather than as a key/value in a dict todisplacy_options- but we can obviously undo this.visualizefunction because none of the base models will have labeled spans in them, so it wouldn't display anything useful.visualize_ner:manualargument because there's no such option for that with displaCy for spansspan_key. This removes thekeysandlabelsargs.Extra:
show_tableargument onvisualize_ner(as well asvisualize_spans)Open questions:
readme.mddocumentation so we can include the new function?