Addresses issue #30 for passing extra options to visualize_ner.#31
Merged
ines merged 20 commits intoexplosion:masterfrom Dec 30, 2021
Merged
Conversation
svlandeg
reviewed
Dec 21, 2021
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks so much for this PR! In the original issue you mentioned extending scope - would you want to do that as a separate PR or as part of this one?
Co-authored-by: Sofie Van Landeghem <[email protected]>
…ons of colors arg from visualize_ner method.
svlandeg
reviewed
Dec 27, 2021
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for the adjustements! I talked to @ines quickly as well and we'd propose renaming the variable to displacy_options - I think I've added all required changes as review suggestions. Otherwise I think this is good to go!
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
ines
reviewed
Dec 27, 2021
ines
reviewed
Dec 27, 2021
ines
reviewed
Dec 27, 2021
Co-authored-by: Ines Montani <[email protected]>
…ya6/spacy-streamlit into extra-options-visualize-ner
Contributor
|
Thanks for your patience with us 🙏 and thanks again for the PR! 🎉 |
Contributor
Author
|
Always a pleasure to contribute to spaCy projects! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.