Pass manual=True to visualize_ner#27
Conversation
|
Hello callistachang, at first, thank you for your PR. I would suggest two minor changes to it such that two possible errors are catched. Maybe you could catch these two things (e.g., using an if-else-statement) and post a streamlit warning instead such that the user understands the origin of the warning. The first possible error occurs when the user sets |
|
Maintenance note: I'll put this PR in draft until we've been able to iron out the UX details. Feel free to move it back in "for review" once all comments are addressed! @callistachang : If you have time to look into making these edits, feel free to add them directly to this PR. If you don't have time right now, let us know, and we can do them ourselves to make sure the PR gets into a state where we can merge it. |
Error 1: When manual=True but show_table=True Error 2: When manual=True but doc is not of type 'list'
|
Sorry for the delay, I must have missed the notifications! Hope this suffices for error checking |
|
Great, thank you for adding the warning messages and also thank you again for your PR! |
3 participants
Adjusted
visualize_nerto includemanualas an argument that is passed intodisplacy_render, and added a new file03_visualize-ner-manual.pyto show how it works.Let me know if this PR can be improved, as this is one of my first open-source contributions, and I am still learning :)
Closes #14