Skip to content

Handling visualize ner#26

Merged
svlandeg merged 12 commits intoexplosion:masterfrom
Jette16:handling_visualize_ner
Oct 6, 2021
Merged

Handling visualize ner#26
svlandeg merged 12 commits intoexplosion:masterfrom
Jette16:handling_visualize_ner

Conversation

@Jette16
Copy link
Copy Markdown
Contributor

@Jette16 Jette16 commented Oct 6, 2021

Adjusted visualize_ner():

  • Streamlit shows a warning when labels are empty instead of an empty table
  • When the function is started with empty labels-list, labels is overwritten with ent.labels_
  • Only the selected labels are shown in the table and the table is only shown when there is any data in variable data

svlandeg
svlandeg reviewed Oct 6, 2021
View reviewed changes
svlandeg
svlandeg approved these changes Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had one minor suggestion for the error msg :-)

@Jette16 @svlandeg
Update spacy_streamlit/visualizer.py
976d436 
Co-authored-by: Sofie Van Landeghem <[email protected]>
@svlandeg svlandeg merged commit aa9d029 into explosion:master Oct 6, 2021
@svlandeg svlandeg mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@svlandeg svlandeg svlandeg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jette16 @svlandeg