Displacy serve entity linking support without manual=True support.#9748
Merged
svlandeg merged 7 commits intoexplosion:masterfrom Nov 29, 2021
Merged
Conversation
… support is only limited to the manual option in displacy.render
svlandeg
added
enhancement
svlandeg
reviewed
Nov 26, 2021
Contributor
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for the PR, much appreciated! Also good to see an additional test for the new functionality. I had just a few small comments.
Co-authored-by: Sofie Van Landeghem <[email protected]>
svlandeg
reviewed
Nov 27, 2021
svlandeg
reviewed
Nov 27, 2021
Contributor
|
Looks good to me, just want to run this by @ines as well :-) |
Co-authored-by: Sofie Van Landeghem <[email protected]>
Co-authored-by: Sofie Van Landeghem <[email protected]>
ines
approved these changes
Nov 29, 2021
Member
ines
left a comment
ines
left a comment
There was a problem hiding this comment.
Yes, looks good 🎉 And really appreciate the test and docs update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds support for visualizing kb_id on entities when run via displacy.serve
Description
The PR adds support for visualizing kb_id on entities when run via displacy.serve. The recent changes from PR 9199 only address rendered html produced with the
manual=Trueoption set. I believe the same should also be afforded when passingDocobjects with entities that have thekb_idset.For the
kb_urlto be set, one can pass thekb_url_format_template(can be named better?) in theoptionsargument ofdisplace.serve. If not set,kb_urldefaults to#similar to the setting in the above linked PR. Please suggest if there is a better way to do this.Types of change
Enhancement
Checklist