Skip to content

Add NEL visualisation (links to entities in a knowledge base)#9199

Merged
ines merged 10 commits intoexplosion:masterfrom
shigapov:master
Sep 23, 2021
Merged

Add NEL visualisation (links to entities in a knowledge base)#9199
ines merged 10 commits intoexplosion:masterfrom
shigapov:master

Conversation

@shigapov
Copy link
Copy Markdown
Contributor

@shigapov shigapov commented Sep 13, 2021

Description

Current NER visualiser cannot show links to entities in a knowledge base. This PR adds NEL visualisation using manual=True option in displaCy.

Types of change

This is enhancement, see issue 9129.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added enhancement Feature requests and improvements feat / nel Feature: Named Entity linking feat / visualizers Feature: Built-in displaCy and other visualizers labels Sep 13, 2021
svlandeg
svlandeg reviewed Sep 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, much appreciated! I have some small comments, but I think this looks good in general. I'll also ping Ines to see whether she might want to review, too :-)

@svlandeg svlandeg requested a review from ines September 15, 2021 20:45
@svlandeg svlandeg linked an issue Sep 15, 2021 that may be closed by this pull request
Displacy vizualization for entity linking #9129
Closed
shigapov
shigapov commented Sep 16, 2021
View reviewed changes
ines
ines reviewed Sep 20, 2021
View reviewed changes
shigapov
shigapov commented Sep 20, 2021
View reviewed changes
shigapov
shigapov commented Sep 20, 2021
View reviewed changes
shigapov
shigapov commented Sep 20, 2021
View reviewed changes
@ines ines merged commit beb4a8c into explosion:master Sep 23, 2021
@narayanacharya6 narayanacharya6 mentioned this pull request Nov 26, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ines ines ines left review comments

+1 more reviewer

@svlandeg svlandeg svlandeg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Feature requests and improvements feat / nel Feature: Named Entity linking feat / visualizers Feature: Built-in displaCy and other visualizers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Displacy vizualization for entity linking

3 participants

@shigapov @svlandeg @ines