This repository was archived by the owner on Nov 23, 2022. It is now read-only.
Update traefik.js #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to try traefik custom ports. If it will work - then we could improve this
Contributor
Author
|
So - config would look like: traefikPorts:
- '7788/tcp':
- HostPort: '3000'
- '7788/udp':
- HostPort: '3000' |
yamalight
suggested changes
Apr 5, 2021
Contributor
yamalight
left a comment
yamalight
left a comment
There was a problem hiding this comment.
A few small requests:
- Please add tests for new feature
- Please open issue / PR with docs on main repo
Contributor
Author
|
Sorry about allot of commits - have no ability to run tests locally hope you able to squash commits |
FDiskas
added a commit
to FDiskas/exoframe
that referenced
this pull request
Apr 5, 2021
Documentation for exoframejs/exoframe-server#43
This was referenced Apr 5, 2021
yamalight
approved these changes
Apr 5, 2021
Contributor
|
Looks good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to try traefik custom ports. If it will work - then we could improve this