Skip to content
This repository was archived by the owner on Nov 23, 2022. It is now read-only.

Add install script #39

Merged
yamalight merged 14 commits into from
May 8, 2020
Merged

Add install script #39

yamalight merged 14 commits into from
May 8, 2020

Conversation

@FDiskas
Copy link
Contributor

@FDiskas FDiskas commented Apr 26, 2020 •
edited
Loading 

bash -c "$(curl -fsSL https://raw.github.com/exoframejs/exoframe-server/master/tools/install.sh)"

Available arguments:

-D, --dry-run     Dry run. Print command instead of executing it.
-e, --email       Enter email to enable SSL support.
-d, --domain      Enter exoframe-server domain.
-p, --password    Enter your private key used for JWT encryption.

@coveralls
Copy link

coveralls commented Apr 26, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 88.149% when pulling ac52a0b on FDiskas:install-script into 21a6ab9 on exoframejs:master.

@FDiskas
Copy link
Contributor Author

FDiskas commented Apr 26, 2020

Default values suppose to work but on mac it's not :( 🌍

read -p 'Enable ssl? Press Enter for none: ' -i 'true' ssl
read -p 'Enter your server domain: ' -i "$HOSTNAME" domain
read -p 'Enter /path/to/exoframe-folder should be path on your server: ' -i '~/.exoframe' config
read -p 'Enter /home/user/.ssh/authorized_keys should point to your authorized_keys file: ' -i '~/.ssh' ssh
read -sp 'Enter your private key used for JWT encryption: ' -i 'your_private_key' passvar

yamalight
yamalight suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! pretty solid starting point. I do have a few requests.

Note on default params on macos - macos uses old-ish Bash that doesn't support -i, this can be worked around with:

read -p "Question? (default: /bar): " var
[ -z "${var}" ] && var='/bar'

@FDiskas
Copy link
Contributor Author

FDiskas commented Apr 27, 2020

Thanks for review. Going to fix that today or tomorrow

FDiskas added a commit to FDiskas/exoframe that referenced this pull request Apr 27, 2020
@FDiskas
Update ServerInstallation.md
90aed12 
Updated readme in case exoframejs/exoframe-server#39 will be merged
This was referenced Apr 27, 2020
Merged
Merged
@FDiskas
Copy link
Contributor Author

FDiskas commented Apr 27, 2020 •
edited
Loading

  • Add --dry-run flag that prints command (and config) instead of executing
  • Add tests

@FDiskas
Copy link
Contributor Author

FDiskas commented Apr 27, 2020

Usage:

-D, --dry-run       Dry run. Print command instead of executing it.
-e, --email           Enter email to enable SSL support.
-d, --domain        Enter exoframe-server domain.
-p, --password    Enter your private key used for JWT encryption.

@FDiskas FDiskas requested a review from yamalight April 28, 2020 07:23
@yamalight yamalight changed the base branch from master to develop April 28, 2020 10:20
yamalight
yamalight suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there, just a few small things :)

@FDiskas FDiskas requested a review from yamalight April 29, 2020 21:11
yamalight
yamalight approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the work 👍

@yamalight
Copy link
Contributor

yamalight commented May 1, 2020

@FDiskas tests seems to fail in CI for some reason though 🤔

@FDiskas
Copy link
Contributor Author

FDiskas commented May 1, 2020

Yes, it fails because the script is broken. I will fix. Currently during the test script asks for email input (bug) so timeout happens

yamalight
yamalight suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor things here. Almost done 🙌

yamalight
yamalight approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the work :)

@yamalight yamalight merged commit d84c4d9 into exoframejs:develop May 8, 2020
@FDiskas FDiskas deleted the install-script branch May 10, 2020 06:20
yamalight pushed a commit to exoframejs/exoframe that referenced this pull request May 11, 2020
@FDiskas
Update ServerInstallation.md (#292)
7d5ec91 
* Update ServerInstallation.md

Updated readme in case exoframejs/exoframe-server#39 will be merged

* Update ServerInstallation.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yamalight yamalight yamalight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FDiskas @coveralls @yamalight