Skip to content

fix: preserve Hermes delivery in skipped job previews - #274

Closed
Subodh-17 wants to merge 1 commit into
existence-master:mainfrom
Subodh-17:fix/hermes-preview-deliver-key
Closed

Subodh-17 wants to merge 1 commit into
existence-master:mainfrom
Subodh-17:fix/hermes-preview-deliver-key

Conversation

@Subodh-17

@Subodh-17 Subodh-17 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Preserve hermes_deliver in every Hermes job preview, including jobs skipped early because they were already imported or have invalid schedules.
  • Initialize the field in the shared job information dictionary using the existing normalization logic.
  • Add regression assertions for skipped jobs to verify the field and delivery values are retained.

Testing

  • pytest tests/migrate/test_hermes.py — 40 passed
  • ruff check sentient tests — passed
  • git diff --check — passed

Fixes #256

Summary by CodeRabbit

  • Bug Fixes
    • Job previews now retain the original Hermes delivery value for both skipped and importable jobs, including Telegram and local delivery.

@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c12d99d1-450a-4d24-b09a-be9c9ae8c56f

📥 Commits

Reviewing files that changed from the base of the PR and between 9b22479 and 94c7698.


📒 Files selected for processing (2)
  • sentient/migrate/hermes.py
  • tests/migrate/test_hermes.py

 ___________________________________________________________________________________________________________________________________
< Finish what you start. Where possible, the routine or object that allocates a resource should be responsible for deallocating it. >
 -----------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@itsskofficial

Copy link
Copy Markdown
Contributor

Thanks @Subodh-17, and sorry for the clash! #273 fixes the same issue and was opened a little earlier (the author asked to take #256 first), so I'm closing this one as a duplicate. Your fix is good, so please pick another one. These good first issues are free:

Comment on the issue first so I can assign it to you and nobody else starts it.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hermes import preview: skipped jobs have no hermes_deliver

2 participants