Allow selecting different calendars in clock widget#3230
Merged
Conversation
Owner
|
please explain me how its fixes #2590 PS: i'm not telling that its a bad PR, just not related to the math in the time |
Contributor
Author
|
The initial proposal was to allow subtracting a specific number from year (for Japan it would be 2019 to mark Reiwa era). However, I believe it is better to leave date format calculation to the OS which already supports a bunch of different calendars, including these with different dates and months - some calendars don't start on 1 Jan. It won't allow counting years from any arbitrary date as it's limited to a few custom ones though. Both calendars: Japanese (Wareki) and Taiwanese (Minguo) are supported by this change. Mac settings allow to customize it in similar fashion: |
Owner
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #2590 by allowing to customize calendar to be used in clock widget.
Available options vary between OS versions though.