Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 94.02% 94.08% +0.05%
==========================================
Files 1 1
Lines 201 203 +2
==========================================
+ Hits 189 191 +2
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
foster999
changed the title
foster999
force-pushed
the
nested-parse-titles
branch
from
dfb352a to
4569ffe
Compare
Collaborator
Author
Daltz333
approved these changes
Feb 6, 2021
Collaborator
Daltz333
left a comment
Daltz333
left a comment
There was a problem hiding this comment.
Not as familiar with the HTML changes, but the Python looks fine. I'll trust the tests.
Collaborator
Author
|
Thanks! If interested, the main difference is that the tab labels are now correctly parsed into HTML, rather than being left as raw reStructuredText. So the reST |
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.0.0 stopped parsing reST content within tab labels. Re-implemented here. This feature was already included in tests, so test regression is also fixed here.
The example:
Produces:
Fixes #100 and fixes #101