Skip to content

Support for sphinx 7 and onwards#131

Closed
LecrisUT wants to merge 4 commits intoexecutablebooks:mainfrom
LecrisUT:sphinx-7
Closed

Support for sphinx 7 and onwards#131
LecrisUT wants to merge 4 commits intoexecutablebooks:mainfrom
LecrisUT:sphinx-7

Conversation

@LecrisUT
Copy link
Copy Markdown

@LecrisUT LecrisUT commented Jun 17, 2023 •
edited
Loading

Closes #130

@welcome
Copy link
Copy Markdown

welcome bot commented Jun 17, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@LecrisUT
Copy link
Copy Markdown
Author

LecrisUT commented Jun 17, 2023

Actually all tests are passing on my fork 🎉 LecrisUT#1

@LecrisUT LecrisUT mentioned this pull request Jun 18, 2023
Merged
@RobPasMue RobPasMue mentioned this pull request Jun 21, 2023
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (537e0d0) 89.97% compared to head (454dd84) 89.97%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files          11       11           
  Lines         948      948           
=======================================
  Hits          853      853           
  Misses         95       95
Flag Coverage Δ
pytests 89.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FloLey
Copy link
Copy Markdown

FloLey commented Jun 23, 2023

@choldgraf in case you missed it and sorry for the ping if you are not the one I should have pinged :)

@michaelweinold michaelweinold mentioned this pull request Jun 27, 2023
Closed
2 tasks
@FloLey FloLey mentioned this pull request Jun 27, 2023
Merged
FloLey added a commit to inmanta/inmanta-dev-dependencies that referenced this pull request Jun 27, 2023
@FloLey
hold back sphinx updates (#303)
93fbec6 
sphinx conflicts with sphinx-design and we are waiting on: executablebooks/sphinx-design#131
@sblauth sblauth mentioned this pull request Jun 29, 2023
Closed
@michaelweinold
Copy link
Copy Markdown

michaelweinold commented Jul 7, 2023

Hello, hello! Any update on this?

@AA-Turner
Copy link
Copy Markdown

AA-Turner commented Jul 24, 2023

@chrisjsewell -- sorry for the ping, would it be possible to look at this PR to support Sphinx 7 in sphinx-design please? From my perspective all seems fine, but I'm not sure who has permissions to do a release on the executable books team.

Thanks,
Adam

@chrisjsewell
Copy link
Copy Markdown
Member

chrisjsewell commented Jul 27, 2023

superceded by #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Sphinx 7

5 participants

@LecrisUT @FloLey @michaelweinold @AA-Turner @chrisjsewell