[FIX] IndexError when parsing incomplete urls without a host part#7
Merged
hukkin merged 3 commits intoexecutablebooks:masterfrom Apr 12, 2022
Merged
[FIX] IndexError when parsing incomplete urls without a host part#7hukkin merged 3 commits intoexecutablebooks:masterfrom
hukkin merged 3 commits intoexecutablebooks:masterfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
This was referenced Apr 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 6 6
Lines 296 296
=======================================
Hits 228 228
Misses 68 68
Continue to review full report at Codecov.
|
|
Congrats on your first merged pull request in this project! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an incomplete url without host like "http://" a IndexError will be thrown. In contrast to this the upstream javascript version returns an almost empty parse result:
url {protocol: 'http:', slashes: true, auth: null, port: null, hostname: '', pathname: null, search: null, hash: null}The IndexError occurs in Python on accessing an array with a negative index. In contrast, in javascript a negative index results in the value "undefined".
See also executablebooks/markdown-it-py#205