Skip to content

Conversation

@robscotts4rb
Copy link

Inline strings that previously met the XML spec, caused the parsing of the files to fail.

Inline strings that previously met the XML spec, caused  the parsing of the files to fail.
@robscotts4rb
Copy link
Author

@guyonroche I couldn't find the correct place to add tests around parsing of a file. If you can point me in the correct direction I am happy to add them

@guyonroche
Copy link
Collaborator

guyonroche commented Mar 7, 2018

@robscotts4rb sorry it's taken me so long to get to this.
If you could add some tests that would be fantastic. The best file would be spec/unit/xlsx/xform/sheet/cell-xform.spec.js

Would this mean we should be writing inline strings as

<c t="inlineStr"><t> ... </t></c> ?

Or do you think that might cause more problems than it solves?

@linguamatics-pdenes
Copy link

@guyonroche I tried to something similar in #501 and added a very basic unit test in there -- hope it makes sense!

@guyonroche
Copy link
Collaborator

@robscotts4rb thanks for the contribution - I'm going to merge #501 and close this one as they are both working to the same end

@guyonroche guyonroche closed this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants