Skip to content

Fixed exceptions when defined name value aren't valid cell reference #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agdevbridge wants to merge 1 commit into from
Closed

Fixed exceptions when defined name value aren't valid cell reference #127

agdevbridge wants to merge 1 commit into from

Conversation

@agdevbridge
Copy link

@agdevbridge agdevbridge commented May 27, 2016

Defined name values can be not only references, for example I have received excel with =#REF!#REF! and it crashed node during processing.

Original stack-trace:

TypeError: Cannot read property '0' of null
    at Object.module.exports.decodeAddress (node_modules/exceljs/lib/utils/col-cache.js:111:36)
    at Object.module.exports.decodeEx (node_modules/exceljs/lib/utils/col-cache.js:197:26)
    at Object.CellMatrix.addCell (node_modules/exceljs/lib/utils/cell-matrix.js:36:29)
    at node_modules/exceljs/lib/doc/defined-names.js:176:16
    at Array.forEach (native)
    at Function._.each._.forEach (node_modules/underscore/underscore.js:78:11)
    at node_modules/exceljs/lib/doc/defined-names.js:175:9
    at Array.forEach (native)
    at Function._.each._.forEach (node_modules/underscore/underscore.js:78:11)
    at Object.model (node_modules/exceljs/lib/doc/defined-names.js:173:7)
    at Object.model (node_modules/exceljs/lib/doc/workbook.js:146:30)
    at node_modules/exceljs/lib/xlsx/xlsx.js:601:31
    at tryCatcher (node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (node_modules/bluebird/js/main/promise.js:581:18)
    at Promise._settlePromiseAtPostResolution (node_modules/bluebird/js/main/promise.js:245:10)
    at Async._drainQueue (node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/bluebird/js/main/async.js:133:10)
    at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/main/async.js:15:14)
    at processImmediate [as _immediateCallback] (timers.js:383:17)

@priitliivak
Copy link
Contributor

priitliivak commented Sep 5, 2016

Any plans to merge this in near future?

priitliivak added a commit to priitliivak/exceljs that referenced this pull request Sep 5, 2016
@priitliivak
Changes from exceljs#127 applied to latest version
66daa4c
@guyonroche
Copy link
Collaborator

guyonroche commented Sep 6, 2016

Closing this in favour of #179

@guyonroche guyonroche closed this Sep 6, 2016
guyonroche added a commit that referenced this pull request Sep 6, 2016
@guyonroche
Merge pull request #179 from priitliivak/master
f3b5a05 
Changes from #127 applied to latest version
This was referenced Mar 30, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agdevbridge @priitliivak @guyonroche