Repository navigation
Conversation
…ext (excalidraw#9281) actionSaveToActiveFile.keyTest was case-sensitive (event.key === KEYS.S). With CapsLock ON, event.key is uppercase 'S', so the WYSIWYG editor's onkeydown skipped the save branch and never called preventDefault() — letting the browser default 'Save Page As' fire instead of saving the .excalidraw file. Fix: use event.key.toLowerCase() (matches actionSaveFileToDisk.keyTest).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionSaveToActiveFile.keyTestwas case-sensitive (event.key === KEYS.S). When CapsLock is ON,event.keyis uppercase"S", so the shortcut no longer matches.While editing a text element, the WYSIWYG editor's
onkeydown(packages/excalidraw/wysiwyg/textWysiwyg.tsx) relies onactionSaveToActiveFile.keyTestto intercept Ctrl/Cmd+S and callpreventDefault()+ save. With CapsLock the keyTest fails, the save branch is skipped,preventDefault()is not called, and the browser default "Save Page As" fires instead of saving the.excalidrawfile. This is the bug reported in #9281.Fix
Make the keyTest case-insensitive:
event.key.toLowerCase() === KEYS.S. This matches the existingactionSaveFileToDisk.keyTest(already case-insensitive withevent.key.toLowerCase()).Tests
Added
packages/excalidraw/tests/saveShortcutTextEditing.test.tsx:event.key === "S") must save +preventDefault(reproduces the bug — fails before this fix, passes after).preventDefault.preventDefault).Scope
packages/excalidraw/actions/actionExport.tsx— 1-line behavior change thekeyTest.packages/excalidraw/tests/saveShortcutTextEditing.test.tsx— new regression test.Closes #9281