Repository navigation
[#3280] Fix RepeatForever reset - #3873
Merged
eonarheim merged 2 commits intoOct 24, 2026
Merged
Conversation
Member
|
@snowyukitty Looks totally reasonable to me, I'll take a closer look today. Many thanks! |
Excalibur benchmarkCommit Baseline
No test is more than 20% slower than the baseline. Results are informational, shared CI runners are noisy. Produced by the code under test on a hosted runner without a GPU. Per-frame charts and full error text are in the job summary and |
Member
|
@snowyukitty Thanks for the fix! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3280
RepeatForever.reset()was a no-op, so stopped repeats could not be reused and running repeats continued their current sequence. Reset now stops the active child and recalls the builder, matchingRepeat.reset()and restarting at the first action from the entity's current state. Requests from a child callback rebuild after its update, so the first action is preserved; a later stop cancels the pending reset.Adds twelve regressions for stopped-action reuse, movement cancellation, delay restart, builder order across repeated resets, empty builders, outer queue reset, and parallel/sequence composition. Includes JSDoc and a changelog entry. Reset intentionally retains the current transform, differing from the issue's suggested return to the default position and matching finite Repeat.
Validation: native Chromium action tests (126 passed; all eleven reset regressions fail on the original implementation), full Chromium unit project (2,175 passed, 210 skipped; clean base: 2,163 passed, 210 skipped), formatter, lint, engine type check, and production/development builds. Visual snapshots and API documentation were not run locally.