fix: normalize root to always include trailing slash before path replacement - #1381
Merged
Conversation
Copilot created this pull request from a session on behalf of
mrexox
April 7, 2026 07:38
View session
mrexox
reviewed
Apr 7, 2026
mrexox
reviewed
Apr 7, 2026
mrexox
force-pushed
the
copilot/fix-issue-1380-validation
branch
from
April 7, 2026 09:33
a7cb9f9 to
c5a9511
Compare
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1380
Context
root: "client"androot: "client/"refer to the same directory but produced different results — the former yielded.//src/index.jsbecausebyRootdid a naive string replacement without ensuring the matcher ended with/.Changes
filter.go— normalizematcherto always have a trailing/before the prefix check and replacement inbyRootfilter_test.go— fix test expectations that encoded the broken double-slash behavior;path: "folder"andpath: "folder/"now both produce./subfolder/0.rb