Skip to content

Fix crash on attach/detach in the same tick#427

Merged
tmm1 merged 1 commit intoeventmachine:masterfrom
pietern:attach-detach
Mar 26, 2013
Merged

Fix crash on attach/detach in the same tick#427
tmm1 merged 1 commit intoeventmachine:masterfrom
pietern:attach-detach

Conversation

@pietern
Copy link
Copy Markdown
Contributor

@pietern pietern commented Mar 25, 2013

Remove descriptor from NewDescriptors when it is detached to fix this issue.

@pietern
Copy link
Copy Markdown
Contributor Author

pietern commented Mar 25, 2013

Please hold off on merging this; it seems to introduce a failure in tests/test_idle_connection.rb.

@pietern
Copy link
Copy Markdown
Contributor Author

pietern commented Mar 25, 2013

It only fails when EM.epoll is set, regardless of this patch being applied or not.

tmm1 added a commit that referenced this pull request Mar 26, 2013
Fix crash on attach/detach in the same tick
@tmm1 tmm1 merged commit 7f5e231 into eventmachine:master Mar 26, 2013
@ibc
Copy link
Copy Markdown
Contributor

ibc commented Apr 2, 2013

It seems that this patch makes the test_idle_time(TestIdleConnection) to fail:

<0> expected but was
<3.044585943222046>

tmm1 added a commit that referenced this pull request Apr 2, 2013
@ibc
Copy link
Copy Markdown
Contributor

ibc commented Apr 2, 2013

Works :)

@pietern pietern deleted the attach-detach branch July 13, 2013 16:43
sodabrew pushed a commit to sodabrew/eventmachine that referenced this pull request Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants