Fix SMTP server behaviour to reset mail transaction state after sending message#351
Merged
tmm1 merged 1 commit intoeventmachine:masterfrom Feb 28, 2013
Conversation
tmm1
added a commit
that referenced
this pull request
Feb 28, 2013
…-mail Fix SMTP server behaviour to reset mail transaction state after sending message
sodabrew
pushed a commit
to sodabrew/eventmachine
that referenced
this pull request
Jan 27, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC in fact does mandate that multiple messages may be sent on a connection without calling RSET or similar. For example, Gmail's outgoing SMTP servers try to do this.
Without this fix, the provided SMTP server will break when trying to reset multiple messages without RSET in between.