Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
=====================================
- Coverage 56% 56% -1%
=====================================
Files 89 89
Lines 9791 9797 +6
Branches 1826 1827 +1
=====================================
- Hits 5497 5495 -2
- Misses 3923 3930 +7
- Partials 371 372 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4586340 to
eee5cee
Compare
|
Note that for prereleases you need to be more specific in GitHub Actions, you can't just say "3.13" until 3.13 is actually out. |
|
Thanks @itamarst for the syntax fix. |
|
Indeed the beta suffix seems the right way to do that, kudos |
|
It looks like 3.13 beta2 has only partially made it through the GitHub Actions support process; they did first part yesterday, so might become available today. So at minimum need to wait for that and rerun tests. It's unclear to me why macOS is failing with a different kind of error. |
itamarst
left a comment
There was a problem hiding this comment.
Need to reach state where tests can actually run, blocked on GitHub Actions (no point in running on old beta).
|
version": "3.13.0-beta.1" seems the last version available for Python 3.13 |
No rush we can pause it during a couple of day. Python 3.13 will be officially released in October. |
|
Concerning macOS, I think we have to use |
|
Progress, of sorts. |
|
We can track progress here: python-greenlet/greenlet#396 |
That's a concerning problem, and far from our responsibility though... |
|
It's being worked on, at least, so seems OK. |
|
Looks like greenlet now supports 3.13. |
|
Some 3.13 tests are now timing out, here's why: |
|
As per python-greenlet/greenlet#425, the current approach to just reusing
Just another example of the ways this project is unsustainable, then. |
|
Thanks for your feedback. Unfortunatelly, from an openstack point of view, I don't think we will be able to ignore 3.13... I need to discuss that point with the infra team to see when they plan to introduce this python version in our supported runtimes. Will back soon with details from our agenda. |
|
That's fine, solving this is totally doable, just wanted to make sure it's worth someone spending time on. |
|
@itamarst Does this PR looks ok for review/merge, or do you plan to add something more into this branch? |
|
Given 3.13 is unusable in this branch, the PR should not be merged yet. |
|
ack, thanks |
|
Hi, I tried your change on the stable Python 3.13 and the tests still throw an error. Hope that helps. |
|
Thanks @MeggyCal all contributions are welcome :) |
|
A newer version of this got merged. If you are seeing bugs in the released version on 3.13, please open new issues. |
Fixes #964
Supporting Python 3.13 as it will become soon a reality https://devguide.python.org/versions/