Skip to content

Make sure asyncio hub doesn't use greendns for asyncio DNS APIs#938

Merged
4383 merged 3 commits intomasterfrom
936-make-sure-asyncio-hub-+-dnspython-work-correctly-together
Mar 15, 2024
Merged

Make sure asyncio hub doesn't use greendns for asyncio DNS APIs#938
4383 merged 3 commits intomasterfrom
936-make-sure-asyncio-hub-+-dnspython-work-correctly-together

Conversation

@itamarst
Copy link
Copy Markdown
Contributor

Fixes #936

@itamarst itamarst linked an issue Mar 14, 2024 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56%. Comparing base (1c869fb) to head (569e4ab).

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #938   +/-   ##
=====================================
- Coverage      56%    56%   -1%     
=====================================
  Files          89     89           
  Lines        9764   9766    +2     
  Branches     1818   1818           
=====================================
  Hits         5473   5473           
- Misses       3918   3921    +3     
+ Partials      373    372    -1     
Flag Coverage Δ
ipv6 23% <0%> (-1%) ⬇️
py310asyncio 52% <100%> (-1%) ⬇️
py310epolls 53% <0%> (-1%) ⬇️
py310poll 53% <0%> (-1%) ⬇️
py310selects 53% <0%> (-1%) ⬇️
py311asyncio 52% <100%> (-1%) ⬇️
py311epolls 53% <0%> (-1%) ⬇️
py312asyncio 50% <100%> (-1%) ⬇️
py312epolls 51% <0%> (-1%) ⬇️
py37asyncio 50% <100%> (+<1%) ⬆️
py37epolls 51% <0%> (-1%) ⬇️
py38asyncio 51% <100%> (+<1%) ⬆️
py38epolls 53% <0%> (-1%) ⬇️
py38openssl 51% <0%> (-1%) ⬇️
py38poll 53% <0%> (-1%) ⬇️
py38selects 53% <0%> (-1%) ⬇️
py39asyncio 51% <100%> (-1%) ⬇️
py39dnspython1 51% <0%> (-1%) ⬇️
py39epolls 53% <0%> (-1%) ⬇️
py39poll 53% <0%> (-1%) ⬇️
py39selects 52% <0%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itamarst itamarst marked this pull request as ready for review March 14, 2024 15:45
@itamarst itamarst requested a review from 4383 March 14, 2024 15:46
@itamarst
Copy link
Copy Markdown
Contributor Author

Lacking the monkeypatching it does infinite recursion, but apparently that doesn't always happen given we have examples that work 🤷 Anyway this should fix it.

@4383 4383 merged commit 1612191 into master Mar 15, 2024
@4383 4383 deleted the 936-make-sure-asyncio-hub-+-dnspython-work-correctly-together branch March 15, 2024 07:50
@4383 4383 mentioned this pull request Mar 15, 2024
clrpackages pushed a commit to clearlinux-pkgs/pypi-eventlet that referenced this pull request Jul 10, 2024
…rsion 0.36.1

0.36.1
======

* [fix] eventlet.websocket is not always used from eventlet.wsgi, so do not assume eventlet.set_idle exists eventlet/eventlet#949

0.36.0
======

* [fix] Make sure asyncio hub doesn't use greendns for asyncio DNS APIs eventlet/eventlet#938
* [fix] Make asyncio.to_thread work with the same semantics as normal asyncio eventlet/eventlet#930
* [fix] Refactor congruence checks based on assert at runtime eventlet/eventlet#932
* [tests] Run tests on macOS in CI, and some fixes to get it in reasonable state (#list eventlet/eventlet#934
* [fix] Fix wsgi.server shutdown for in-flight requests eventlet/eventlet#912
* [feature] Add debug convenience helpers - asyncio, threads eventlet/eventlet#925
* [fix] Handle errors better. eventlet/eventlet#923

(NEWS truncated at 15 lines)

CVEs fixed in this build:
CVE-2023-29483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure asyncio hub + dnspython work correctly together

3 participants