Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
=====================================
Coverage 55% 55%
=====================================
Files 90 90
Lines 9880 9880
Branches 1832 1832
=====================================
Hits 5460 5460
Misses 4045 4045
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4383
reviewed
Jan 17, 2024
Member
4383
left a comment
4383
left a comment
There was a problem hiding this comment.
Good job! Globally this PR LGTM, I just have some suggestions and questions inline.
…o-use-it-for-migration-path-off-of-eventlet
Member
|
Would be worth publishing this doc with tag 0.35.0 |
4383
deleted the
891-document-asyncio-integration-and-how-to-use-it-for-migration-path-off-of-eventlet
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.