Reword maintenance policy sentences#882
Merged
4383 merged 1 commit intoeventlet:masterfrom Jan 16, 2024
Merged
Conversation
Member
Author
|
@osfrickler: o/ here is the following patches |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
=====================================
Coverage 55% 55%
=====================================
Files 89 89
Lines 9837 9844 +7
Branches 1828 1831 +3
=====================================
+ Hits 5414 5419 +5
- Misses 4054 4056 +2
Partials 369 369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
osfrickler
reviewed
Jan 15, 2024
osfrickler
left a comment
osfrickler
left a comment
There was a problem hiding this comment.
Thx, apply the same changes to doc/index.rst?
README.rst
Outdated
| those related to the asyncio migration. **Usage in new projects are | ||
| discouraged**. **Our goal is to plan the retirement of eventlet** and to give | ||
| you ways to move away from eventlet. | ||
| Eventlet now follow a new maintenance policy. **Only maintenance for |
Reword sentences to make them more meaningful, fix typos, remove examples to discourage new usages.
4383
force-pushed
the
update-sentences
branch
from
c21b4d6 to
0b32830
Compare
Member
Author
done |
itamarst
approved these changes
Jan 16, 2024
| you ways to move away from eventlet. | ||
| Eventlet now follows a new maintenance policy. **Only maintenance for | ||
| stability and bug fixing** will be provided. **No new features will be | ||
| accepted**, except those related to the asyncio migration. **Usages in new |
Contributor
There was a problem hiding this comment.
Maybe "Using eventlet in new projects is discouraged."?
Member
Author
There was a problem hiding this comment.
let's update this sentence later if really needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reword sentences to make them more meaningful, fix typos, remove examples to discourage new usages.