Ignore asyncore and asynchat for Python 3.12+#854
Merged
itamarst merged 1 commit intoeventlet:masterfrom Dec 20, 2023
Merged
Conversation
4383
force-pushed
the
condition-asyncore-asynchat
branch
from
800af81 to
f86c355
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
=====================================
- Coverage 53% 53% -1%
=====================================
Files 88 88
Lines 9881 9885 +4
Branches 1852 1854 +2
=====================================
+ Hits 5335 5336 +1
- Misses 4156 4159 +3
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4383
force-pushed
the
condition-asyncore-asynchat
branch
from
f86c355 to
bc1057d
Compare
Starting Python 3.12 these modules have been removed https://docs.python.org/3/whatsnew/3.12.html Fix eventlet#804
4383
force-pushed
the
condition-asyncore-asynchat
branch
from
bc1057d to
b94d73a
Compare
itamarst
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting Python 3.12 these modules have been removed
https://docs.python.org/3/whatsnew/3.12.html
Fix #804