Skip to content

Replace nose with pytest#836

Merged
4383 merged 12 commits intomasterfrom
638-wip-remove-dependency-on-nose
Dec 14, 2023
Merged

Replace nose with pytest#836
4383 merged 12 commits intomasterfrom
638-wip-remove-dependency-on-nose

Conversation

@itamarst
Copy link
Copy Markdown
Contributor

@itamarst itamarst commented Dec 14, 2023

Fixes #638

Unless nose3 starts being maintained again, this is a prerequisite for Python 3.12 support. nose3 is, in any case, essentially a dead project.

  • Everything passes in CI
  • Everything runs in CI. nose runs 722 tests, pytest now runs 722 tests too.

@itamarst itamarst linked an issue Dec 14, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97dc606) 32% compared to head (2d4c3cf) 53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #836     +/-   ##
=======================================
+ Coverage      32%    53%    +21%     
=======================================
  Files          88     88             
  Lines       14979   9848   -5131     
  Branches     1515   1841    +326     
=======================================
+ Hits         4857   5299    +442     
+ Misses       9773   4164   -5609     
- Partials      349    385     +36     
Flag Coverage Δ
ipv6 22% <ø> (+10%) ⬆️
py310epolls 52% <ø> (+16%) ⬆️
py310poll 52% <ø> (+16%) ⬆️
py310selects 52% <ø> (+16%) ⬆️
py311epolls 52% <ø> (+21%) ⬆️
py38epolls 52% <ø> (+10%) ⬆️
py38openssl 50% <ø> (+10%) ⬆️
py38poll 52% <ø> (+10%) ⬆️
py38selects 51% <ø> (+10%) ⬆️
py39dnspython1 50% <ø> (+10%) ⬆️
py39epolls 52% <ø> (+10%) ⬆️
py39poll 52% <ø> (+10%) ⬆️
py39selects 51% <ø> (+10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4383
Copy link
Copy Markdown
Member

4383 commented Dec 14, 2023

I'm ok to move from nose to pytest, motivations (#638) looks legit.

@itamarst
Copy link
Copy Markdown
Contributor Author

This is fun. nose when running tests does 722 tests, when you run nosetests --collect-only it finds 723 😭

@itamarst itamarst marked this pull request as ready for review December 14, 2023 16:55
'README.rst'
)
).read(),
test_suite='nose.collector',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was for setup.py test, which is now deprecated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, no problem

@itamarst itamarst changed the title WIP: remove dependency on nose Replace nose with pytest Dec 14, 2023
@4383
Copy link
Copy Markdown
Member

4383 commented Dec 14, 2023

This is fun. nose when running tests does 722 tests, when you run nosetests --collect-only it finds 723

I'm just guessing... Maybe 'SkipTest' is just skipped at runtime or something like that, and so, and therefore counted only in other cases (collect), although it seems unlikely that we'll skip only a single test...

Copy link
Copy Markdown
Member

@4383 4383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God job! Thanks @itamarst

@4383 4383 merged commit 1c2fb7a into master Dec 14, 2023
@4383 4383 deleted the 638-wip-remove-dependency-on-nose branch December 14, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WIP: Remove dependency on nose

3 participants