greendns: Use _compute_times on dnspython 2#639
Closed
jayvdb wants to merge 3 commits intoeventlet:masterfrom
Closed
greendns: Use _compute_times on dnspython 2#639jayvdb wants to merge 3 commits intoeventlet:masterfrom
jayvdb wants to merge 3 commits intoeventlet:masterfrom
Conversation
jayvdb
force-pushed
the
dnspython2
branch
5 times, most recently
from
5de3822 to
2a34eb7
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Contributor
Author
Member
|
@jayvdb thanks for your work and please check this #619 (comment) |
temoto
requested changes
Aug 19, 2020
In dnspython v2.0.0, "_compute_expiration" was replaced by "_compute_times". Once the minimum version of dnspython is v2.0.0, we can remove this wrapping method. Related to eventlet#629
Contributor
Author
|
@temoto re that issue, I can reproduce that other problem on openSUSE releases (15.1 and 15.2), but not on the rolling release Tumbleweed which I use locally , and I wasnt able to identify exactly what the cause was. I posted some backtraces and thoughts at rthalley/dnspython#559 (comment) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rthalley/dnspython@52f46fc0 for the dnspython change this is fixing.
Mostly fixes dnspython 2, except minor failures. c.f. #619