Issue #274: Fix GreenSocket.recv_into() #275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix recv_into(), recvfrom(), recvfrom_into() and sendto() methods of GreenSocket to handle blocking I/O errors (ex: BlockingIOError on Python 3). Even if the trampoline was called, the socket method can still fails with an I/O errors for various reasons (see manual pages of the C functions for examples). Ref: #274
Contributor
Author
|
I completed my patch to fix the bug in more methods: "fix recv_into(), recvfrom(), recvfrom_into() and sendto() methods of GreenSocket to handle blocking I/O errors". |
Contributor
Contributor
|
I completely missed the fact that this breaks tests on Python 3, just reverted, sorry. |
Contributor
|
Do you think there could be a bugfix release of eventlet? I need this patch to fix a bug in OpenStack (https://bugs.launchpad.net/bugs/1521756). |
Contributor
|
I think I can update the change log by tomorrow (there are more changes than this, some of them breaking backwards compatibility) and then it's up to @temoto to upload it. |
Contributor
Author
|
Cool, thank you.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GreenSocket.recv_into(): if fd.recv_into() fails with a blocking I/O error: calls the trampoline in a loop, until the call succeed.