Fix GreenFileIO.readall() for regular file #257
Conversation
|
ping? |
|
Hey @Haypo, do you mind moving the code in |
GreenFileIO.readall() calls _trampoline(self, read=True). Problem: on regular file, epoll_ctl() fails with EPERM on Linux, because regular files are not supported. This change skips the call to _trampoline() on regular files. Add also various unit tests on the various ways to read the whole content of a file.
Sure, it's done. |
| if get_errno(e) not in SOCKET_BLOCKING: | ||
| raise IOError(*e.args) | ||
| self._trampoline(self, read=True) | ||
| if not self._is_regular: |
There was a problem hiding this comment.
According to stat() documentation, file descriptor may be a regular file, directory, symlink, block or char device, socket and fifo. What are supported types? Is it possible to use white list instead? Check that fd is of supported type.
There was a problem hiding this comment.
hm. looking at this again actually makes me wonder if #314 is a better fix. the problem is triggered when we call epoll.register on a regular file, but we should only be doing that when we catch something in SOCKET_BLOCKING. if i understand things correctly, this should never be raised from regular files.
|
this should be fixed by #314 |
|
Sorry, I'm not interested to update this old pull request anymore, so I just close it. |
|
problem is already fixed by #314 i think |
4 participants
GreenFileIO.readall() calls _trampoline(self, read=True). Problem: on
regular file, epoll_ctl() fails with EPERM on Linux, because regular
files are not supported.
This change skips the call to _trampoline() on regular files. Add
also various unit tests on the various ways to read the whole content
of a file.