GH #248: Fix GreenFileIO.write() #250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python 3, GreenFileIO.write() now always write all bytes using a loop, to have the same behaviour than GreenPipe.write() on Python 2. Before, the write() could be partial, write less bytes than expected. On Python 2, GreenPipe.write() doesn't allow partial writes, it always write all bytes, even if the user requested an unbuffered pipe (ex: by calling os.fdopen(fd, 'wb', 0)). Modifying Python 2 to be pedantic and allow partial writes for unbuffered pipes will likely break a lot of applications. It's simpler to modify Python 3 GreenFileIO to behave the same than Python 2 GreenPipe.
Contributor
Author
|
Hi, any progress on this change? |
Member
|
Thank you, the fix is merged in master e3f8834 |
Contributor
Author
Member
|
Yup, sorry, for some reason I wanted a green build this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3, GreenFileIO.write() now always write all bytes using a
loop, to have the same behaviour than GreenPipe.write() on Python 2.
Before, the write() could be partial, write less bytes than expected.
On Python 2, GreenPipe.write() doesn't allow partial writes, it
always write all bytes, even if the user requested an unbuffered pipe
(ex: by calling os.fdopen(fd, 'wb', 0)).
Modifying Python 2 to be pedantic and allow partial writes for
unbuffered pipes will likely break a lot of applications. It's
simpler to modify Python 3 GreenFileIO to behave the same than Python
2 GreenPipe.