Fix patching of removed URLopener class in Python 3.14#1053
Merged
4383 merged 1 commit intoeventlet:masterfrom Jun 19, 2025
Merged
Conversation
The class urllib.request.URLopener has been removed in Python 3.14: python/cpython#125739 Because of this, trying to run the tests in `test__greenness.py` fails with the following on Python 3.14: ``` ERROR tests/test__greenness.py - NameError: name 'URLopener' is not defined ``` Update the patching so that we only do it for Python versions lower than 3.14.
allhailwesttexas
force-pushed
the
peter/skip-urlopen-patch-if-not-exists
branch
from
aaeb44a to
523a8df
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
======================================
- Coverage 56% 56% -1%
======================================
Files 89 89
Lines 9868 9871 +3
Branches 1647 1648 +1
======================================
- Hits 5569 5559 -10
- Misses 3934 3944 +10
- Partials 365 368 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class
urllib.request.URLopenerhas been removed in Python 3.14: python/cpython#125739Because of this, trying to run the tests in
test__greenness.pyfails with the following on Python 3.14:Update the patching so that we only do it for Python versions lower than 3.14.