prevent infinite recursion with linking to current greenthread#1
Merged
temoto merged 1 commit intoeventlet:masterfrom Dec 13, 2012
Merged
Conversation
Member
|
Thank you very much. 👍 Just out of curiosity, could you show an example where one would link inside linked function? Sounds like yo-dawg trolling. :) |
Contributor
Author
|
there's an example in the linked issue report on bitbucket. it probably doesn't make much sense normally to link within a linked function but sometimes things can have an unexpected side-effect that links something to the current greenthread, which is what happens in the given example: A copy of that code example is included below: I think logging in a linked function is not an unexpected pattern. this results in: |
Member
|
Thanks, indeed this looks like a reasonable pattern. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for issue reported at bitbucket: https://bitbucket.org/which_linden/eventlet/issue/133/maximum-recursion-depth-exceeded-bug-more
test included.