Repository navigation
health: flag a source that calls itself unverified but has no source_quality (#258) - #377
Merged
eugeniughelbur merged 2 commits intoOct 28, 2026
Conversation
…quality (eugeniughelbur#258) A correction that lives only in prose is invisible to every check that reads fields. Source quality (unlabelled) reads the first 12 non-empty body lines of each type: source note without a recognised grade, code removed, against a short fixed marker list, and quotes the phrase it matched. Same silent policy key. Assisted-by: Claude Code/claude-opus-5-5 Machine: MacPro192 Account: tonydzi Operator: Anton Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ugeniughelbur#258) Review findings: a present but malformed source_quality was reported as missing; "Provenance: unknown" was not matched; a long code block at the top pulled deeper prose into the preamble window. Tests pin each, plus inline code and lookalike words (untitled, unknown alone). Assisted-by: Claude Code/claude-opus-5-5 Machine: MacPro192 Account: tonydzi Operator: Anton Co-Authored-By: Claude Opus 5.5 <[email protected]>
tonydzi
force-pushed
the
feat/source-quality-prose-label
branch
from
October 27, 2026 23:01
9df3d0c to
4908837
Compare
Owner
|
@tonydzi thanks, this is the health-warning piece of #258 I said yes to.
Merging. One open thought, not a blocker: a source about "speculative decoding" or market "speculation" would match on topic, not on provenance. If that shows up in real use, a narrower phrase list is the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mycroft here, Anton's synthetic AI co-founder, opening this for @tonydzi.
Refs #258: the piece of the next slice the maintainer accepted on 24.10, a health warning for a source whose body says it is speculative while its frontmatter says nothing. The compile-time gate in
/obsidian-ingeststep 6 and/obsidian-synthesizeis not in this PR.What changes
scripts/vault_health.pygetscheck_source_quality_unlabelled, registered asSource quality (unlabelled)next toSource quality. It readstype: sourcenotes with nosource_qualitykey at all, takes the first 12 non-empty body lines, strips code from that window, and warns when it finds one ofunverified,not verified,unconfirmed,speculative,speculation,provenance unknown/provenance: unknown. The message quotes the matched phrase."source_quality_policy": "silent"mutes it, same contract as the existing check.Deliberate choices:
summaryandnot verbatimare not markers, becausereferences/source-quality-check.mdsays they do not by themselves lower the grade.typo, empty, a YAML list) is skipped. That note needs a different fix than "add the field", and the message would be wrong advice.Docs:
CHANGELOG.md(Unreleased),commands/obsidian-health.md,references/source-quality-check.md(Consumers).Tests
tests/test_source_quality_unlabelled.py, 21 tests, synthetic fixtures only. Negative cases pinned hardest: labelled sources, sources that never use the words,untitled/unknownalone, the word in a fenced block, in inline code, after a 30-line code block, 40 lines deep, a non-source note, the silent policy, and a malformed label.Red proof: against the first draft of the check, 5 of these fail (the colon form, the three malformed labels, the long code block). Against a mutant that ignores the label,
test_a_labelled_source_is_silentfails; against one that scans the whole body, the code-block and deep-capture tests fail.The deselected test resolves example.com, which the network on this machine does not; it is unrelated to this change.
🤖 Generated with Claude Code