Repository navigation
Make a fresh vault read clean in the MCP health check - #346
Merged
Merged
Conversation
…#344) obsidian_vault_health reported 10 wanted notes and 2 orphans on a vault straight from bootstrap_vault.py, while scripts/vault_health.py reported 0. - bootstrap: Home.md wrote the table-cell escape `\|` on plain lines, where the backslash stays in the link target and the link fails in Obsidian too. Plain lines now use `|`. The folder links (`[[Daily/|...]]`) never resolve in Obsidian, so they are plain text. - vault_ops: drop a trailing backslash from a wikilink target, as the CLI does, so a correctly escaped link inside a table resolves. Report a target that normalises to nothing instead of skipping it, so a folder link no longer passes unseen. Exempt Home.md and _CLAUDE.md from the orphan check, as the CLI does.
# Conflicts: # CHANGELOG.md
eugeniughelbur
added a commit
that referenced
this pull request
Oct 20, 2026
Owner
|
Merged, thanks @drakeo338. I checked the 4 new tests against the @fbacchin your report named both defects and the exact lines in |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #344. On a vault fresh from
bootstrap_vault.py,obsidian_vault_healthreported 10 wanted notes and 2 orphans whilescripts/vault_health.pyreported 0. Home.md wrote the table-cell escape\|on plain lines and folder links like[[Daily/|...]]that never resolve in Obsidian; bootstrap now writes valid links. The MCPvault_opsnow strips the escaping backslash from link targets, reports targets that normalise to nothing, and exempts Home.md and _CLAUDE.md from the orphan check, as the CLI does.Type of change
Related issues
Closes #344
How I tested it
New
tests/test_mcp_fresh_vault_health.py: 4 failed before the change, 4 pass after.AI-first rule compliance (required for any vault-writing command)
Not applicable, no vault-writing command changed, so these stay unticked.
references/ai-first-rules.md## For future Claudepreambleai-first: true,type:,date:,tags:[[...]]) used for every person, project, idea, decision referenced(as of YYYY-MM, source.com))Checklist
CHANGELOG.md(under "Unreleased") if applicableSKILL.mdand the README's command tableScreenshots / output (if visual or producing notes)
n/a