Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eudev-project/eudev
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.2.12-pre2
Choose a base ref
...
head repository: eudev-project/eudev
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.2.12-pre3
Choose a head ref
  • 5 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 10, 2022

  1. Avoid warning on 32bit

    On 32bit arches where time_t is defined as long int and where
    sizeof(long)==sizeof(int), PRI_TIME is PRIu32 which is "u" and gcc warns about
    ignoring the long part of the integer type. There is no problem besides the
    warning.
    
    Use "lu" in the above conditions and PRIu32 in all other 32bit time_t cases.
    
    udevadm-monitor.c: In function ‘print_device’:
    udevadm-monitor.c:49:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘__time_t’ {aka ‘long int’} [-Wformat=]
       49 |         printf("%-6s[%"PRI_TIME".%06ld] %-8s %s (%s)\n",
          |                ^~~~~~~~
       50 |                source,
       51 |                ts.tv_sec, ts.tv_nsec/1000,
          |                ~~~~~~~~~
          |                  |
          |                  __time_t {aka long int}
    In file included from ../../src/shared/macro.h:26,
                     from udev.h:26,
                     from udevadm-monitor.c:35:
    /usr/include/inttypes.h:104:19: note: format string is defined here
      104 | # define PRIu32  "u"
    bbonev committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b1de2b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Revert "Avoid warning on 32bit"

    This reverts commit b1de2b7.
    bbonev committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    2c969a3 View commit details
    Browse the repository at this point in the history
  2. Avoid warning on 32bit

    On 32bit arches where time_t is defined as long int and where
    sizeof(long)==sizeof(int), PRI_TIME is PRIu32 which is "u" and gcc warns about
    ignoring the long part of the integer type. There is no problem besides the
    warning.
    
    Upcast time_t to 64bit and get rid of PRI_TIME and configure checks
    
    udevadm-monitor.c: In function ‘print_device’:
    udevadm-monitor.c:49:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘__time_t’ {aka ‘long int’} [-Wformat=]
       49 |         printf("%-6s[%"PRI_TIME".%06ld] %-8s %s (%s)\n",
          |                ^~~~~~~~
       50 |                source,
       51 |                ts.tv_sec, ts.tv_nsec/1000,
          |                ~~~~~~~~~
          |                  |
          |                  __time_t {aka long int}
    In file included from ../../src/shared/macro.h:26,
                     from udev.h:26,
                     from udevadm-monitor.c:35:
    /usr/include/inttypes.h:104:19: note: format string is defined here
      104 | # define PRIu32  "u"
    bbonev committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    da0ca7e View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Merge pull request #233 from bbonev/time32warn

    Avoid warning on 32bit
    bbonev authored Jun 12, 2022
    Configuration menu
    Copy the full SHA
    91066e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Configuration menu
    Copy the full SHA
    ba2cff9 View commit details
    Browse the repository at this point in the history
Loading