Fix providers.Resource missing overloads for AbstractContextManager and AbstractAsyncContextManager#927
Merged
ZipFile merged 2 commits intoets-labs:developfrom Oct 10, 2025
Conversation
… AbstractAsyncContextManager
45868a7 to
4bc7e5d
Compare
leonarduschen
commented
Oct 10, 2025
| provider9.set_provides("builtins.dict") | ||
|
|
||
|
|
||
| # Test 10: to check the return type with classes implementing AbstractContextManager protocol |
Contributor
Author
There was a problem hiding this comment.
Test 10 and 12 (classes implementing __(a)enter__/__(a)exit__) were actually already passing because of the first overload Callable[..., T], but I added these tests anyway because they were not covered yet.
ZipFile
approved these changes
Oct 10, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #926
Demo
Runtime:
Mypy output before changing stubs
Mypy output after changing stubs