Skip to content

Comments

Yet another Pydantic 2 support#832

Merged
rmk135 merged 4 commits intoets-labs:developfrom
ZipFile:pydantic2
Dec 7, 2024
Merged

Yet another Pydantic 2 support#832
rmk135 merged 4 commits intoets-labs:developfrom
ZipFile:pydantic2

Conversation

@ZipFile
Copy link
Contributor

@ZipFile ZipFile commented Nov 30, 2024

This PR supersede #803, #786, #785 (partially), #768 and fixes #755, #726.

Notable differences:

  • Updated GHA pipeline to run tests against two versions of Pydantic.
  • Better error messages depending on installed Pydantic version.
  • Minor code de-duplication.

There is one necessary but unrelated commit to fix compatibility with httpx v0.27.0. Without this change tests are failing.

@coveralls
Copy link

Coverage Status

coverage: 94.261% (+0.02%) from 94.246%
when pulling 8cec99d on ZipFile:pydantic2
into cab75cb on ets-labs:develop.

Copy link
Member

@rmk135 rmk135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants