Added support for pydantic-settings in Configuration.from_pydantic()#768
Added support for pydantic-settings in Configuration.from_pydantic()#768tsaryapkin wants to merge 1 commit intoets-labs:developfrom
Conversation
|
Hey @tsaryapkin , @rmk135 @tsaryapkin Thanks a lot for this update, I'm currently blocked from using this lib with a new project because of this issue and this would help a lot. @rmk135 Is it possible to review this PR soon ? Thanks ! |
I second this! |
|
Hi @rmk135 Any plans to merge this soon? Thank you |
|
Hi @rmk135 @tsaryapkin, Could you please review the changes and merge the updates if possible? |
|
Hi @rmk135 @tsaryapkin, Any plans on merging these updates in the latest future? Thanks in advance! |
|
@wordedword75049 here are mentioned some workarounds that can potentially unblock you: #755 |
|
@rmk135 Could someone review this PR that’s been sitting untouched for over a year? |
|
@naem1023 thanks for highlighting this. I started looking at the pydantic 2 support yesterday and came to a pretty similar idea on the implementation. This PR has already been implemented nicely (thanks to @tsaryapkin ). However, we won't be able to merge it since there are a few merge conflicts. There have been a few changes made in the code since this PR was created. I'll see if I can resolve those conflicts myself or maybe will take the code to build a new branch and thank @tsariapkin for his contribution in the changelog and the contributors file. @tsariapkin , if you have a moment to deal with the conflicts, that'd be much appreciated too. Otherwise, thanks for that contribution. Nicely done! |
Configurationprovider can be initialised via from_pydantic method from both pydantic.BaseSettings (pydantic v1) and pydantic_settings.BaseSettings (based on pydantic v2).