Allow Closing to detect dependent resources passed as kwargs too #636#653
Allow Closing to detect dependent resources passed as kwargs too #636#653federinik wants to merge 5 commits intoets-labs:masterfrom
Conversation
|
Hey, any plans to review and merge this one ? |
|
Friendly reminder that this 2-lines PR (rest is just testing) has been open and unmerged for 3 months now |
|
Hey, @federinik! I have recently encountered the same issue as you, plus some more (#702 has some details on one of the problems I faced), and started making changes to |
|
Hi @jazzthief, sure thing, feel free to include what I wrote in a common PR/branch or, if you prefer, I could give you access to my fork of the project. Anyway, I'm not really optimistic about receiving soon updates from the reviewers, this PR has been open a while now, unluckily. Let me know how I can help! |
|
@federinik Thank you! I would really like to somehow preserve this PR and give credit to the fact that you first found this problem. So I think I am going to open a PR to combine all the changes and ask you to change your PR's target branch to mine. This way, I can merge your PR and have control over the description of all the changes I am going to make. Does that work for you? |
|
Hi @jazzthief, sound good to me. Let me know when everything is set up and I'll open a PR to your branch. Thank you! |
|
@federinik I've created the PR: #711. The branch I work on is |
federinik
force-pushed
the
master
branch
3 times, most recently
from
7195cbd to
f3d7e68
Compare
|
Changes integrated in PR #711, I'm closing this. Thank you all! |
3 participants
A small addiction to the work of @StummeJ about issue #633 which allows to benefit of his improvement even for dependencies passed as kwargs (such as my case)