Repository navigation
Refactor capture and transformation handles - #59
Conversation
Release GIL in device_get_capture
Fixes, Example
# Conflicts: # example/threads.py # pyk4a/pyk4a.cpp
Reformat code Add type hintings Fix code errors
Refactor tests. Patch module for tests.
# Conflicts: # README.md # pyk4a/pyk4a.cpp
Refactor tests
get_previouse_capture support
shagren
changed the title
|
@lpasselin can you review this minor ;-) PR ? |
lpasselin
left a comment
lpasselin
left a comment
There was a problem hiding this comment.
Amazing work, we are really lucky that you worked on this project!
I left some small comments but nothing major that can't be merged already.
Great job on the testing. I did not go into details for the tests yet but I will when implementing the body tracking.
Thanks for the PR it's great work again!
| You must open device before querying any information | ||
| """ | ||
| if self.opened: | ||
| raise K4AException("Device already opened") |
There was a problem hiding this comment.
Do we need to raise exception here? or do nothing is already open
There was a problem hiding this comment.
I prefer to raise exception here.
Let's leave as is and review open/start logic in future.
I.e. _start_imu and _start_cameras can be public: use can start only required modules.
|
Let me know when you feel it is ready to merge into develop. I'll test with my device then. |
|
@lpasselin , i think this PR can be merged now. |
Fix will start workign with pytest 6.1 see pytest-dev/pytest#7700
Big refactoring