Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing feature dependency issue where the stacks crate uses reqwest's JSON functionality without declaring the required feature flag. Additionally, it improves the development workflow by ensuring the bacon check command tests all features.
Changes:
- Added
jsonfeature to reqwest dependency in stacks crate - Updated bacon.toml check command to include
--all-featuresflag for better feature coverage during development
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/stacks/Cargo.toml | Adds features = ["json"] to reqwest dependency, which is required for .json() method calls used in the stacks crate |
| bacon.toml | Adds --all-features flag to check command and reformats to multi-line array for better readability, aligning with CI configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.