bugfix: anvil fork sync incorrectly fetching fork block#1506
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Anvil fork synchronization where the fork block number was being incorrectly fetched and used. The fix addresses issue #1503 by correcting the JSON path to access Anvil's fork configuration and adjusting the backfill start block calculation to properly skip the fork block itself.
Key changes:
- Corrected the path to fetch
forkBlockNumberfrom Anvil'sanvil_nodeInfoRPC response (now properly accessingforkConfig.forkBlockNumber) - Fixed the HTTP provider's backfill logic to start from
fork_block_number + 1instead offork_block_number - Minor formatting improvements to import ordering and struct initialization
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/sync/anvil/src/tracker/utils.rs | Corrects the JSON path to access fork block number from Anvil's node info, now properly accessing it via forkConfig.forkBlockNumber |
| crates/sync/anvil/src/tracker/http.rs | Fixes backfill starting block calculation to properly start from fork_block_number + 1 to avoid re-processing the fork block |
| crates/sync/anvil/src/expanders.rs | Formatting changes: reordered imports and reformatted Tx struct initialization for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1503