better error message on invalid alchemy key#1496
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the settings crate by providing more detailed error messages from API validation and standardizing error handling patterns.
- Enhanced Alchemy API key validation to extract and display specific error messages from HTTP responses
- Standardized error handling in actor message passing to provide clearer error context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/settings/src/utils.rs | Added detailed error extraction from Alchemy API responses, parsing JSON error messages to provide better user feedback |
| crates/settings/src/actor.rs | Replaced wrap_err_with with explicit match-based error handling for actor message passing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require alchemy api keys to support at least eth mainnet
when that doesn't happen, the key is deemed invalid, but the settings UI was not being clear about this reason
The new approach propagates certain http errors from the test function back to the UI