Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive logging capabilities to ethui, including persistent log file storage and a live log viewer UI. Log files are automatically created for each session in ~/.config/ethui/logs/ with timestamped filenames, and users can view and filter logs in real-time through a new Logging section in Settings.
Key changes:
- New logging UI with live streaming, search filtering, and ANSI color support
- Buffered file logging that transitions from memory to disk after initialization
- Relocated Rust log level configuration from General to the new Logging settings page
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gui/src/routes/home/_l/settings/_l/logging.tsx | New settings page with live log viewer, ANSI parsing, and filter functionality |
| gui/src/routes/home/_l/settings/_l/general.tsx | Removed Rust log level input (moved to logging page) |
| gui/src/routes/home/_l/settings/_l.tsx | Updated container styling for flexible layout |
| gui/src/routeTree.gen.ts | Generated route definitions for new logging page |
| gui/src/components/WalletSidebar/index.tsx | Added conditional shadow styling |
| gui/src/components/AppSidebar.tsx | Added Logging menu item to settings navigation |
| crates/tracing/src/lib.rs | Implemented file logging with buffering and session management |
| crates/tracing/Cargo.toml | Added chrono dependency for timestamps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
joaocosta9
approved these changes
Nov 3, 2025
Collaborator
joaocosta9
left a comment
joaocosta9
left a comment
There was a problem hiding this comment.
Did not review the code meticulously, but tested on mac and is working as expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethui now outputs a file to
~/.config/ethui/logs/<timestamp>logwith the live logs withRUST_LOG=ethui=debug.For every new ethui session, a new file is created.
I also added a new Logging section to the settings where this file can be streamed in real time